Fix system_queries test to actually test the problem #7613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you change the base for this PR to the main? We normally merge everything into main and then cherry-pick to the release branches, but we didn't follow that approach by accident for #7604 |
Green-Chan
force-pushed
the
fix-system_queries-test
branch
from
db2cd82 to
b53b2cd
Compare
Green-Chan
force-pushed
the
fix-system_queries-test
branch
from
b53b2cd to
64384dd
Compare
gurkanindibay
approved these changes
Jun 25, 2024
auto-merge was automatically disabled
July 16, 2024 06:57
Head branch was pushed to by a user without write access
Green-Chan
force-pushed
the
fix-system_queries-test
branch
from
0b4f9c2 to
5359d21
Compare
|
I've rebased the branch to updated main. |
Green-Chan
force-pushed
the
fix-system_queries-test
branch
from
5359d21 to
1db28fa
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❌ Your project status has failed because the head coverage (81.47%) is below the target coverage (87.50%). You can increase the head coverage or adjust the target coverage.
Additional details and impacted files@@ Coverage Diff @@
## main #7613 +/- ##
==========================================
- Coverage 89.61% 81.47% -8.15%
==========================================
Files 283 283
Lines 60518 60296 -222
Branches 7544 7486 -58
==========================================
- Hits 54236 49124 -5112
- Misses 4124 8414 +4290
- Partials 2158 2758 +600 |
Green-Chan
force-pushed
the
fix-system_queries-test
branch
from
1db28fa to
bd5849f
Compare
Green-Chan
force-pushed
the
fix-system_queries-test
branch
from
bd5849f to
49263cd
Compare
|
Finally all required tests have passed! |
Green-Chan
force-pushed
the
fix-system_queries-test
branch
from
49263cd to
857c38d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test added in #7604 doesn't reach the
HasRangeTableReffunction and thus doesn't test what it should.