Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to build with warning - control reaches end of non-void function Werror=return-type" #7680

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SeleznevPavel
Copy link

We have a product where the warning Werror=return-type is enabled and is treated as an error for the entire build process. So our build process stops. Of course, we can do tricks in the build script, but I guess this commit will be useful because it removes one excluded warning.

@SeleznevPavel
Copy link
Author

SeleznevPavel commented Aug 30, 2024

@microsoft-github-policy-service agree company="Sbertech"
@microsoft-github-policy-service agree

@SeleznevPavel
Copy link
Author

@hanefi @thanodnl

This pull request stopped my work on the main product - I can't modify the Citus sources in the project I am working on currently. Do you think it's possible to merge this pull request into the main branch?

Also, I didn't know how the review process is organized in Citus project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant