Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust max_prepared_transactions only when it is default #7712

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Adjust max_prepared_transactions only when it is default #7712

wants to merge 3 commits into from

Conversation

Green-Chan
Copy link
Contributor

Fixes #7711.
Change AdjustMaxPreparedTransactions to really check if max_prepared_transactions is explicitly set by user, and only adjust max_prepared_transactions when it is default.
This fixes 021_twophase test failure with loaded Citus library after postgres/postgres@b39c5272.

@Green-Chan
Copy link
Contributor Author

Argh, I always forget to check it with older PG versions. find_option is declared static in guc.c, so it won't work. Check using find_options for PG versions >= 16, and keep the old check for older versions is too ugly, isn't it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

021_twophase test failure
1 participant
@Green-Chan