Fix Isolation Test Failure in isolation_multiuser_locking in PG17 #7714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## naisila/pg17_support #7714 +/- ##
=====================================================
Coverage 89.61% 89.61%
=====================================================
Files 274 274
Lines 59689 59689
Branches 7446 7446
=====================================================
+ Hits 53490 53493 +3
+ Misses 4069 4066 -3
Partials 2130 2130 |
onurctirtir
reviewed
Nov 8, 2024
|
|
||
| step s1-insert: | ||
| UPDATE test_table SET column2 = 1; | ||
| <waiting ...> |
There was a problem hiding this comment.
this seems a bit suspicious as we were throwing a permission-check error in the older test output
There was a problem hiding this comment.
I suppose that because of this commit:
git.postgresql.org Git - postgresql.git/commitdiff
If you think that it is unrelated, ı Will looked into that more.
naisila
force-pushed
the
naisila/pg17_support
branch
from
70cf729
to
e4040dd
Compare
naisila
force-pushed
the
naisila/pg17_support
branch
from
04a8f6a
to
b29c332
Compare
m3hm3t
force-pushed
the
m3hm3t/pg17_isolation_multiuser_lock
branch
from
1fbdd9f
to
94bbb2e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances
isolation_multiuser_locking.spectest compatibility across multiple PostgreSQL versions by handling differences in error messages and behavior. Key updates include:Error Message Handling: Adjustments to manage version-specific error messages, ensuring consistent test results.
Modified to address variations in locking behavior across PostgreSQL versions, ensuring test stability in multiuser scenarios.
REINDEX Behavior Adjustment: This PR accounts for a behavioral change introduced in PostgreSQL by commit ecb0fd337, which alters how REINDEX interacts with system catalogs.
https://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=ecb0fd337