Fix foreign_key_to_reference_shard_rebalance test (#7400) #7826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foreign_key_to_reference_shard_rebalance failed because partition of 2024 year does not exist, fixed by add default partition. Replaces #7396 by adding a rule that allows properly testing foreign_key_to_reference_shard_rebalance via run_test.py. Closes #7396 Co-authored-by: chuhx <[email protected]> (cherry picked from commit 968ac74)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-13.0 #7826 +/- ##
===============================================
Coverage ? 89.62%
===============================================
Files ? 274
Lines ? 59749
Branches ? 7452
===============================================
Hits ? 53548
Misses ? 4066
Partials ? 2135 |
onurctirtir
approved these changes
Dec 31, 2024
tejeswarm
pushed a commit
that referenced
this pull request
Jan 7, 2025
foreign_key_to_reference_shard_rebalance failed because partition of 2024 year does not exist, fixed by add default partition. Replaces #7396 by adding a rule that allows properly testing foreign_key_to_reference_shard_rebalance via run_test.py. Closes #7396 Co-authored-by: chuhx <[email protected]> (cherry picked from commit 968ac74) Co-authored-by: Onur Tirtir <[email protected]>
onurctirtir
added a commit
that referenced
this pull request
Jan 7, 2025
foreign_key_to_reference_shard_rebalance failed because partition of 2024 year does not exist, fixed by add default partition. Replaces #7396 by adding a rule that allows properly testing foreign_key_to_reference_shard_rebalance via run_test.py. Closes #7396 Co-authored-by: chuhx <[email protected]> (cherry picked from commit 968ac74) Co-authored-by: Onur Tirtir <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
foreign_key_to_reference_shard_rebalance failed because partition of 2024 year does not exist, fixed by add default partition.
Replaces #7396 by adding a rule that allows properly testing foreign_key_to_reference_shard_rebalance via run_test.py.
Closes #7396
Co-authored-by: chuhx [email protected]
(cherry picked from commit 968ac74)