Skip to content

Merge v0.4.13 into master - #504

Merged
RetricSu merged 2 commits into
masterfrom
develop
Aug 17, 2026
Merged

Merge v0.4.13 into master#504
RetricSu merged 2 commits into
masterfrom
develop

Conversation

@RetricSu

Copy link
Copy Markdown
Collaborator

No description provided.

…once (fixes #498) (#501)

- Make the balance address argument required so `offckb balance` prints
  `error: missing required argument 'toAddress'` instead of leaking the
  SDK's `Unknown address format undefined`.
- Only emit commander errors through logger.failure in JSON mode; in
  human mode commander's writeErr already printed the line once, so
  re-emitting duplicated every commander error on stderr.
@github-actions

Copy link
Copy Markdown

Missing Changeset

Please add a changeset describing your changes:

pnpm changeset

If your changes do not need a version bump (docs, CI, refactoring),
add the skip-changeset label to this PR.

For dependency updates, use the dependencies label.

@coderabbitai

coderabbitai Bot commented Aug 17, 2026

Copy link
Copy Markdown

Review Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: afb52393-4202-425a-af78-7fd8a6b37fe0

📥 Commits

Reviewing files that changed from the base of the PR and between be56ce4 and 44ab81d.

📒 Files selected for processing (4)
  • CHANGELOG.md
  • package.json
  • src/cli.ts
  • tests/cli-errors.test.ts

Included review availability: Your plan includes up to 1 review per rolling hour; 0 remain after this review.


📝 Walkthrough

Summary by CodeRabbit

  • Bug Fixes
    • offckb balance now requires an address and reports a clear missing-argument error when omitted.
    • Command-line errors for missing arguments, unknown options, and invalid values are displayed only once.
    • JSON output continues to provide structured error details with appropriate exit codes.
  • Documentation
    • Added release notes for version 0.4.13.
  • Release
    • Updated the package version to 0.4.13.

Walkthrough

The CLI now requires an address for balance. Non-JSON Commander errors are emitted once, while JSON mode retains structured errors. Tests cover error output, exit codes, and valid balance requests. The package version and changelog were updated to 0.4.13.

Changes

CLI validation and error handling

Layer / File(s) Summary
CLI contract, error handling, and regression tests
src/cli.ts, tests/cli-errors.test.ts, package.json, CHANGELOG.md
balance now requires toAddress. Non-JSON Commander errors are not emitted twice. Tests cover missing arguments, invalid options, JSON errors, exit codes, and valid balanceOf calls. The package version and changelog are updated to 0.4.13.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 44ab8

This PR is merge-ready after normal checks and review; no actionable merge-blocking risk remains.

Possibly related PRs

Suggested labels: skip-changeset

Suggested reviewers: humble-little-bear

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ❓ Inconclusive No pull request description was provided, so it does not explain the v0.4.13 CLI and error-handling changes. Add a brief description of the v0.4.13 CLI argument and error-handling changes.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title identifies the v0.4.13 release merge into master and matches the pull request’s stated objective.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@RetricSu
RetricSu merged commit 1551ef9 into master Aug 17, 2026
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants