Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI #167

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Fix CI #167

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8640b73
Update `circleci/browser-tools`
KarolDawidziuk Feb 13, 2025
926a39d
Test: fix failing test
KarolDawidziuk Feb 13, 2025
1c6ab0b
test
KarolDawidziuk Feb 13, 2025
1db6a01
Cleanup
KarolDawidziuk Feb 13, 2025
7159cb1
Increase timeout
KarolDawidziuk Feb 14, 2025
3810fac
Update baePath in the unit test
KarolDawidziuk Feb 14, 2025
aeb75cf
Pin chai version.
Comandeer Feb 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
version: 2.1
orbs:
browser-tools: circleci/browser-tools@1.4.6
browser-tools: circleci/browser-tools@1.5.2

workflows:
test:
Expand Down
2 changes: 1 addition & 1 deletion karma.conf.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ module.exports = function( config ) {
},
client: {
mocha: {
timeout: 3000
timeout: 5000
},
args: [
process.env.CKEDITOR_LICENSE_KEY
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"@babel/preset-env": "^7.20.2",
"@vue/test-utils": "^1.3.4",
"babel-loader": "^8.3.0",
"chai": "^4.3.7",
"chai": "4.3.7",
"core-js": "^3.27.2",
"eslint": "^8.33.0",
"eslint-config-ckeditor5": "^3.1.1",
Expand Down
2 changes: 1 addition & 1 deletion tests/integration.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ describe( 'Integration of CKEditor component', () => {
} );

it( 'should use correct CKEDITOR build', () => {
const basePath = 'https://cdn.ckeditor.com/4.23.0-lts/standard-all/';
const basePath = 'https://cdn.ckeditor.com/4.25.1-lts/standard-all/';

return createComponent( { editorUrl: basePath + 'ckeditor.js' } ).then( comp => {
expect( window.CKEDITOR.basePath ).to.equal( basePath );
Expand Down