Removed rules related to build packages #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psmyrek
approved these changes
Feb 12, 2025
There was a problem hiding this comment.
LGTM 🎉
Please update the merge commit message to include:
- an entry for
eslint-config-ckeditor5package which no longer has theno-build-extensionrule in the CKEditor 5 configuration, - an entry for
eslint-plugin-ckeditor5-rulespackage with a short note that the rule has been removed, - in the major breaking change entry, please inform not only about removing the rule, but also add short explanation why the rule has been removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Other: The
ckeditor5-rules/no-build-extensionsis no longer available. Read more details in ckeditor/ckeditor5#17779.MAJOR BREAKING CHANGE (eslint-config-ckeditor5): The
ckeditor5-rules/no-build-extensionsrule is no longer included in the configuration.MAJOR BREAKING CHANGE (eslint-plugin-ckeditor5-rules): Removed the
ckeditor5-rules/no-build-extensionsrule due to the removal of predefined builds.Additional information
For example – encountered issues, assumptions you had to make, other affected tickets, etc.