Fullscreen mode feature bootstrap #17810
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docs: Introduced Enhanced Source Code Editing documentation and samples. Other (ui): Added Enhanced Source Code Editing as a default menu bar item, making it visible in the menu bar when the plugin is present in the editor. Fix (utils): Extended `getEnvKeystrokeText` with option to use it in the context of specified env which allows to generate keystrokes text for different OS than the host one. Other (utils): Extended key codes with `End` and `Home` keys, enabling the use and display of shortcuts containing these keys in the UI.
Other (engine): Introduced dynamic caching in `Mapper` in order to improve view-to-model mapping performance, and as a result improve editor data load and data save performance. Closes #17623. Other (engine): New parameter `data` was added for `change:children` event fired by `ViewElement` and `ViewDocumentFragment` when their children change. `data` is an object with `index` property, which says at which index the change happened. Related to #17623. Other (engine): `Mapper#registerViewToModelLength()` is now deprecated and will be removed in one of upcoming releases. Note: if this method is used, the caching mechanism for `Mapper` will be turned off which may degrade performance when handing big documents. Note: this method is used by the deprecated legacy lists feature. See #17623. MINOR BREAKING CHANGE (engine): `Mapper#registerViewToModelLength()` is now deprecated and will be removed in one of the upcoming releases. This method is useful only in obscure and complex converters, where model element, or a group of model elements, are represented very differently in the view. We believe that every feature that uses custom view-to-model length callback can be rewritten in a way that this mechanism is no longer necessary. Note: if this method is used, the caching mechanism for `Mapper` will be turned off which may degrade performance when handing big documents. Note: this method is used by the deprecated legacy lists feature. As a result, you will not experience the performance improvements if you are still using deprecated legacy lists feature.
…ocs-fix Docs: Fix Mapper API docs.
Internal: Inserting an emoji over a non-collapsed selection removes the selected text. Closes #17819.
Internal: Added `@ckeditor/ckeditor5-source-editing-enhanced` as a project dependency.
Fix (engine): The link `rel` attribute will now allow mixing manual link decorators for the same attribute, as it will be now handled as a token list. Closes #13985, closes #6436. Fix (mention): Mention should not be wrapped with an additional `<span>` when GHS is enabled. Closes #15329. Internal (html-support): Attribute matching updated to the new output of `Matcher#matchAll()`. MINOR BREAKING CHANGE (engine): The `ViewConsumable.consumablesFromElement()` is removed and replaced with `view.Element#_getConsumables()` internal method. You should use `ViewConsumable.createFrom()` To create consumables if needed. MINOR BREAKING CHANGE (engine): The `ViewElementConsumables` now accepts and outputs only normalized data. The `ViewConsumable` still accepts normalized or non-normalized input. MINOR BREAKING CHANGE (engine): The `Matcher#match()` and `Matcher#matchAll()` output is now normalized. The `MatchResult#match` now contains normalized data compatible with changes in the `ViewConsumable`.
Internal: Fixed invalid links in docs snippets.
…a. (#17756) Feature (html-support): Add an experimental `EmptyBlock` plugin that prevents adding ` ` to output data. Other (engine): The whitespaces around a block filler (` `) are ignored while loading editor data.
Dumluregn
force-pushed
the
ck/fullscreen-bootstrap
branch
from
2c75b43 to
f275002
Compare
|
A note regarding the toolbar/menu bar label. There was a proposal to name it "Enter fullscreen mode"/"Leave fullscreen mode". I propose to use just "Fullscreen mode" because: |
|
Can't get to terms with GH about the commit history. Recreated as #17897. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Internal (fullscreen): Introduce a fullscreen mode feature.
Additional information
This PR contains a package bootstrap and a basic working feature.
What should work:
What is not a subject of this PR: