Allow replacing input on the fly #1697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
I'll give it a deep review in two-three days. I'm overwhelmed by other problems right now, sorry. Upon a shallow look, I'm somewhat concerned about performance since now we always clone the input. I don't know what the impact will be and I'm trying to benchmark it now. I know, CLI parsing is rarely a big concern, if at all, but clap has always been outstanding regarding to runtime speed, and some users have been choosing it exactly because of it. By the way, our current benches seem to be useless. |
Yup, I was thinking the same. |
CreepySkeleton
suggested changes
Feb 20, 2020
pksunkara
force-pushed
the
replace
branch
2 times, most recently
from
293a370 to
1f48d76
Compare
CreepySkeleton
approved these changes
Feb 21, 2020
|
bors r+ |
Build succeeded
|
This was referenced Oct 9, 2021
This was referenced Dec 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1603
I tried several different ways of implementing the above requested feature but failed because they always ended up trying to manipulate the input which is a no-go because it was a plain
Iterator. And then the #1693 was filed, and reading it made me think that maybe we should allow input to be changed. So, I extracted it out and made it do the replacing.