[Build] Publish release before Homebrew update#493
Conversation
Signed-off-by: samzong <samzong.lu@gmail.com>
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
|
Hi @samzong, DetailsInstructions for interacting with me using comments are available here. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c22741454d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if [ "$IS_PRERELEASE" = "true" ]; then | ||
| gh release edit "$RELEASE_TAG" --repo ${{ github.repository }} --draft=false --prerelease | ||
| else | ||
| gh release edit "$RELEASE_TAG" --repo ${{ github.repository }} --draft=false --latest |
There was a problem hiding this comment.
Avoid triggering Homebrew tap update twice
For stable tag runs, publishing the Release here also fires .github/workflows/update-homebrew.yml because that workflow is configured with on: release: types: [published], and this same release workflow still later dispatches update-homebrew.yml manually. That creates two tap-update runs for the same tag; if they both checkout the tap before either pushes, one push can be rejected as non-fast-forward or report a duplicate failed release-side workflow even though the assets are valid.
Useful? React with 👍 / 👎.
Summary
Publish GitHub Releases before dispatching the Homebrew tap update so the tap workflow can resolve public release assets.
Type of change
[Feat]new feature[Fix]bug fix[UI]UI or UX change[Docs]documentation-only change[Refactor]internal cleanup[Build]CI, packaging, or tooling change[Chore]maintenanceWhy is this needed?
The stable release flow dispatched
update-homebrew.ymlwhile electron-builder's GitHub Release was still a draft. The tap update then could not see the public release or macOS DMG assets.What changed?
isDraft=false.actionlint/shellcheck passes cleanly.Architecture impact
docs/architecture-invariants.md: noneLinked issues
None.
Validation
pnpm lintpnpm testpnpm buildpnpm check:ui-contractCommands, screenshots, or notes:
Screenshots or recordings
Not UI-facing.
If the change touches renderer styles, layout, spacing, component states, or interaction polish, explain which tokens, variables, states, or
pnpm check:ui-contractrules were intentionally preserved or changed.Not applicable.
Release note
NONE.Checklist
git commit -s)[Feat],[Fix],[UI],[Docs],[Refactor],[Build], or[Chore]