Make it possible to skip package coverage #97
Conversation
|
Doesn't only_list_changed_files do effectively the same thing? |
|
Haven't tried it actually 😀 |
|
@punxaphil I see your point there :-) You did a lot of changes here so I just need to properly walk through them all if you dont mind. But thank you for the work and it will be merged |
__tests__/functions.test.ts
Outdated
| let stdoutWriteCalls = getStdoutWriteCalls() | ||
| expect(stdoutWriteCalls).toMatchSnapshot() |
There was a problem hiding this comment.
Im assuming this was just test broiler plating which I dont think need to necessarily change but just checking
There was a problem hiding this comment.
Good catch. It was for debugging. Reverted!
__tests__/functions.test.ts
Outdated
| let stdoutWriteCalls1 = getStdoutWriteCalls() | ||
| expect(stdoutWriteCalls1).toMatchSnapshot() |
There was a problem hiding this comment.
Im assuming this was just test broiler plating which I dont think need to necessarily change but just checking
There was a problem hiding this comment.
Good catch. It was for debugging. Reverted!
|
Actually looks rather good to me. Ignore the failed CI its because it sometimes has an issue commenting on PRs made from external contributors which I thought should be fixed as a result of this: #64 |
|
@tm1000 Thanks for reviewing! Are we ready to merge, or any other changes needed from me? |
Sometimes the package listing can become really verbose. This change allows the user of the action to only show overall coverage. Example: