Refactoring file handling with minimum backward compatibility breaks #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… still not perfect
VincentChalnot
commented
Apr 22, 2020
| * | ||
| * @return array|null | ||
| */ | ||
| public function readLine($length = null): ?array; |
There was a problem hiding this comment.
We are forced to remove the readLine method because it's too much linked to CSV
VincentChalnot
commented
Apr 22, 2020
| @@ -13,7 +13,7 @@ | |||
| /** | |||
| * Wrapper around JSON files to read them in a stream | |||
| */ | |||
| class JsonStreamFile implements FileStreamInterface, WritableFileInterface | |||
| class JsonStreamFile implements FileStreamInterface | |||
There was a problem hiding this comment.
Maybe there is a mistake here
There was a problem hiding this comment.
Should have been replaced by WritableStructuredFileInterface
|
Not sure about this interface, but at some point, write method was not
compatible with this (wrong return type?)
Le mer. 22 avr. 2020 à 15:44, Vincent Chalnot <[email protected]> a
écrit :
… ***@***.**** commented on this pull request.
------------------------------
In Filesystem/JsonStreamFile.php
<#116 (comment)>
:
> @@ -13,7 +13,7 @@
/**
* Wrapper around JSON files to read them in a stream
*/
-class JsonStreamFile implements FileStreamInterface, WritableFileInterface
+class JsonStreamFile implements FileStreamInterface
Should have been replaced by WritableStructuredFileInterface
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#116 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AARXHKOGQXGW23S5PD6EERTRN3YCZANCNFSM4MOFQDRA>
.
|
|
Too much changes between proposal and main branch => So moved to #160 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying improve the mess in here but it's very difficult without breaking interfaces.