Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

14 quality #17

Merged
merged 7 commits into from
Dec 16, 2024
Merged

14 quality #17

merged 7 commits into from
Dec 16, 2024

Conversation

tonongregory
Copy link
Collaborator

No description provided.

…terable type#'

                                    - '#has parameter .* with no value type specified in iterable type#'
                                    - '#has no value type specified in iterable type array#'
                                    - '#configureOptions\(\) has no return type specified.#'
                                    - '#configure\(\) has no return type specified#'
                                    - '#process\(\) has no return type specified#'
                                    - '#should return Iterator but returns Traversable#'
                                    - '#Negated boolean expression is always false#'
@@ -37,6 +38,16 @@ public function getPrivateProcesses(): array
return array_filter($this->getConfigurations(), fn (ProcessConfiguration $cfg) => !$cfg->isPublic());
}

/**
* @return null|array{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may use @phpstan-type to prevent duplication

@njoubert-cleverage njoubert-cleverage merged commit ebdfa8d into prepare-release Dec 16, 2024
10 checks passed
@njoubert-cleverage njoubert-cleverage added this to the v2.0 milestone Dec 16, 2024
@njoubert-cleverage njoubert-cleverage deleted the 14_quality branch December 17, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants