Skip to content

fix: handle empty response body #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: trunk
Choose a base branch
from
Draft

fix: handle empty response body #162

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
20b3d72
test: adds a tests that showcases #161
nobe4 May 19, 2024
702451a
fix: add check for empty response body
nobe4 May 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions pkg/api/rest_client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,9 +105,11 @@ func (c *RESTClient) DoWithContext(ctx context.Context, method string, path stri
return err
}

err = json.Unmarshal(b, &response)
if err != nil {
return err
if len(b) > 0 {
err = json.Unmarshal(b, &response)
if err != nil {
return err
}
}

return nil
Expand Down
19 changes: 19 additions & 0 deletions pkg/api/rest_client_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,6 +303,25 @@ func TestRESTClientPatch(t *testing.T) {
assert.True(t, gock.IsDone(), printPendingMocks(gock.Pending()))
}

// Covers https://docs.github.com/en/rest/activity/notifications?apiVersion=2022-11-28#mark-a-thread-as-read
func TestRESTClientPatchNoResponseBody(t *testing.T) {
t.Cleanup(gock.Off)
gock.New("https://api.github.com").
Patch("/some/path/here").
BodyString(`{}`).
Reply(205).
BodyString("")
client, _ := NewRESTClient(ClientOptions{
Host: "github.com",
AuthToken: "token",
Transport: http.DefaultTransport,
})
r := bytes.NewReader([]byte(`{}`))
err := client.Patch("some/path/here", r, nil)
assert.NoError(t, err)
assert.True(t, gock.IsDone(), printPendingMocks(gock.Pending()))
}

func TestRESTClientPost(t *testing.T) {
t.Cleanup(gock.Off)
gock.New("https://api.github.com").
Expand Down