[Fix #586] Fix emacs freezing when opening file containing "comment" #651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OknoLombarda
force-pushed
the
fix-freezing-comment
branch
from
4e32a49
to
3315bcf
Compare
bbatsov
reviewed
Jun 8, 2023
bbatsov
reviewed
Jun 8, 2023
OknoLombarda
force-pushed
the
fix-freezing-comment
branch
from
3315bcf
to
98088d2
Compare
OknoLombarda
force-pushed
the
fix-freezing-comment
branch
from
98088d2
to
267afc9
Compare
bbatsov
reviewed
Jun 9, 2023
| @@ -6,6 +6,10 @@ | |||
|
|
|||
| * Font-lock Lein's `defproject` as a keyword. | |||
|
|
|||
| ### Bugs fixed | |||
|
|
|||
| * [#586](https://github.com/clojure-emacs/clojure-mode/issues/586): Fix infinite loop when opening file containing `comment` with `clojure-toplevel-inside-comment-form` set to `t`. | |||
There was a problem hiding this comment.
Btw, is this specific to comment or to just having a single form in the buffer? Looking at the code it's the latter.
There was a problem hiding this comment.
If function clojure-sexp-starts-until-position is called directly, then yes, it will loop forever for any single form in buffer. But this bug is triggered without user doing anything (except for opening the buffer) only when there's just comment in buffer
There was a problem hiding this comment.
It would seem wise to create an issue for that edge case - having a more robust building block would make bugs less likely, in a future.
Other than that it seems good to merge this PR in!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting a PR mark the checkboxes for the items you've done (if you
think a checkbox does not apply, then leave it unchecked):
M-x checkdocand fixed any warnings in the code you've written.Thanks!