[java] Preserve array indicator in member docs and remove reliance on --add-opens in parser-next #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-yakushev
force-pushed
the
doc-arrays
branch
from
22a4bbe
to
526ddcf
Compare
alexander-yakushev
force-pushed
the
doc-arrays
branch
from
526ddcf
to
f8596c3
Compare
alexander-yakushev
force-pushed
the
doc-arrays
branch
from
f8596c3
to
8c6ed35
Compare
alexander-yakushev
changed the title
alexander-yakushev
force-pushed
the
doc-arrays
branch
from
8c6ed35
to
ff639cf
Compare
bbatsov
approved these changes
Oct 24, 2024
|
@vemv Just FYI. |
|
Sure, no issue 🤝 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #278.
The issue is quite confusing. Clojure's
clojure.reflectnamespace when dealing with square brackets[]transforms them to<>for whatever reason. In some places, it then transforms it back, e.g. in functionclojure.reflect/typesym.Orchard in different places removes
<>indicators, possibly presuming they refer to generic arguments. However, with reflection, you can't get generics information anyway, since generics are not a runtime feature.This PR ensures that things like
java.lang.String<>are transformed back tojava.lang.String[], and also doesn't do any "generics removal" for reflection-obtained docs.UPDATE: This PR now also includes the rewrite of parser-next to use public interfaces instead of internal closed-module implementations. It's hard to merge these two big changes separately because some of the tests are inter-reliant.