feat: add file upload component and refactor fetch to work with formData (#2274) #4742
Conversation
| throw new Error('Failed to fetch public files ' + (err?.message || '')); | ||
| }, | ||
| }); | ||
| const [uploadError, setUploadError] = useState(null); |
There was a problem hiding this comment.
@apburnes i know it looks like a lot, but this handles dismissing the alerts (both error and success) after a set duration. I havent added a dismiss click yet.
There was a problem hiding this comment.
That's ok for this PR. Once we pickup the alert mgmt issue, we will pull this into a separate hook.
| setFolderName(''); | ||
| setShowFolderNameField(false); | ||
| } catch (error) { | ||
| setErrorMessage(error.message || 'Failed to create folder.'); |
There was a problem hiding this comment.
right now this is a little redundant. it will show the error in two places.
same for file upload
sknep
force-pushed
the
file-storage-upload-2274
branch
from
ffee6ae to
84018e0
Compare
🤖 This is an automated code coverage reportTotal coverage (lines): 27.1% |
| throw new Error('Failed to fetch public files ' + (err?.message || '')); | ||
| }, | ||
| }); | ||
| const [uploadError, setUploadError] = useState(null); |
There was a problem hiding this comment.
That's ok for this PR. Once we pickup the alert mgmt issue, we will pull this into a separate hook.
| if (baseConfigs.headers['content-type'] === 'multipart/form-data') { | ||
| requestBody = configs.body; | ||
| // browser must set this for FormData | ||
| delete baseConfigs.headers['content-type']; |
There was a problem hiding this comment.
After an upload, do the following requests have the content-type set to application/json?
There was a problem hiding this comment.
they'd get defaultHeaders again which includes 'content-type': 'application/json', unless they have been explicitly given 'content-type'='something-else'
FWIW i think these are supposed to be capitalized "Content-Type" but assumed yall had a reason for the lowercase
sknep
force-pushed
the
file-storage-upload-2274
branch
from
84018e0 to
d55aae1
Compare
sknep
force-pushed
the
file-storage-upload-2274
branch
from
d55aae1 to
86c18e4
Compare
Changes proposed in this pull request:
@shared, with onUpload, onCancel, and triggerOnMount props for use elsewheresecurity considerations