Skip to content

chore: update user collection to mask bot users#269

Merged
apburnes merged 1 commit intomainfrom
chore-hide-site-bot-user
Mar 5, 2026
Merged

chore: update user collection to mask bot users#269
apburnes merged 1 commit intomainfrom
chore-hide-site-bot-user

Conversation

@kevinsmaster5
Copy link
Contributor

@kevinsmaster5 kevinsmaster5 commented Mar 5, 2026

Closes #258

Changes proposed in this pull request:

  • Adds a query modifier to getAdminOrSiteUser() to exclude bot users when access rules are rolled up
  • Add tests for manager and user branch in Users access test

Things to check

  • For any logging statements, is there any chance that they could be logging sensitive data?
  • Are log statements using a logging library with a logging level set? Setting a logging level means that log statements "below" that level will not be written to the output. For example, if the logging level is set to INFO and debugging statements are written with log.debug or similar, then they won't be written to the otput, which can prevent unintentional leaks of sensitive data.

Security considerations

No expected security considerations.

@kevinsmaster5 kevinsmaster5 marked this pull request as ready for review March 5, 2026 19:40
@kevinsmaster5 kevinsmaster5 requested a review from a team as a code owner March 5, 2026 19:40
Copy link
Contributor

@apburnes apburnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈 🤖

@apburnes apburnes merged commit bf37205 into main Mar 5, 2026
7 checks passed
@apburnes apburnes deleted the chore-hide-site-bot-user branch March 5, 2026 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hide site bot user from users list

2 participants