Repository navigation
Conversation
`IommuFd::new()` hardcodes `/dev/iommu`, which does not work in environments where device nodes are exposed at a different location, such as sandboxes or containers that remap `/dev`. `new_from_fd()` covers the case where the caller opens the device itself, but it does not help when the VMM is the one expected to open it. Add `IommuFd::new_from_path()` to open the iommufd character device at an arbitrary path, and make `new()` a thin wrapper around it opening `/dev/iommu`. Drop the hardcoded path from the `OpenIommufd` error message since the source error already carries the failing path. Signed-off-by: Changyuan Lyu <changyuanl@google.com>
Lencerf
requested review from
likebreath,
liuw,
rbradford and
up2wing
as code owners
November 4, 2026 17:27
Lencerf
marked this pull request as draft
November 4, 2026 17:30
Author
|
Dropping this PR as I realized the caller can open iommufd char device file and then call |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IommuFd::new()hardcodes/dev/iommu, which does not work in environments where device nodes are exposed at a different location, such as sandboxes or containers that remap/dev.new_from_fd()covers the case where the caller opens the device itself, but it does not help when the VMM is the one expected to open it.Add
IommuFd::new_from_path()to open the iommufd character device at an arbitrary path, and makenew()a thin wrapper around it opening/dev/iommu. Drop the hardcoded path from theOpenIommufderror message since the source error already carries the failing path.