Reduce size and complexity, enhance cross-platform compatibility, update yamldotnet, update test platforms #197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deps: Standardize von netstandard2.0, instead of netstandard2.0 and net47, for maximum cross-platform compatibility and less module size build: Standardize von netstandard2.0, instead of netstandard2.0 and net47, for maximum cross-platform compatibility and less module size
…latest (instead of outdated and specific versions)
Author
|
Hi @gabriel-samfira! Is this PR something that is of interest for you and powershell-yaml? |
Member
|
Hi @GruberMarkus ! Yes! Very much so. I will try to allocate some time on Monday to have a closer look. Apologies for the delay! Thank you for opening the PR! |
Author
|
Hi @gabriel-samfira! Do you think the PR can be merged, or that it should be adapter or abandoned? |
Member
|
Please don't abandon it. I am currently in crunch mode on another project and it's difficult to split away. I looked over it, looks okay overall, I need to check provenance of binary blobs and run some tests (due diligence with any binary blobs). I will try to get to it as soon as possible. My apologies for the delay! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following: