Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies, prior to a new release #298

Merged
merged 3 commits into from
Aug 2, 2024

Conversation

jskeet
Copy link
Contributor

@jskeet jskeet commented Aug 2, 2024

@captainsafia I'm happy for this to be reviewed by you instead of Josh if you've got the time.

(I must get you onto the official maintainer list...)

jskeet added 3 commits August 2, 2024 08:07
Many of these are just build/test/packaging, but customer-relevant dependency updates are:

- AMQPNetLite and AMQPNetLite.Serialization: 2.4.2 => 2.4.11
- System.Text.Encodings.Web: 6.0.0 => 8.0.0 (only used in netstandard2.0 and netstandard2.1 targets)
- Apache.Avro: 1.11.1 => 1.11.3
- Newtonsoft.Json: 13.0.2 => 13.0.3
- Google.Protobuf: 3.22.0 => 3.27.3
- Confluent.Kafka: 1.6.3 => 1.9.3 (see cloudevents#297 for consideration of a bump to 2.x)

Signed-off-by: Jon Skeet <[email protected]>
The production code behavior hasn't changed here, but Assert.Equal used to pass when presented with an empty string and an empty byte array.

Signed-off-by: Jon Skeet <[email protected]>
@jskeet jskeet requested a review from JoshLove-msft August 2, 2024 08:46
@@ -6,7 +6,7 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="McMaster.Extensions.CommandLineUtils" Version="3.1.0" />
<PackageReference Include="McMaster.Extensions.CommandLineUtils" Version="4.1.1" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idle thought that doesn't require a reaction in this PR but maybe we benefit from introducing a Directory.Packages.props to the repo?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not something I'm familiar with - will add an issue to remind me to look into it :)

@jskeet jskeet merged commit bad80eb into cloudevents:main Aug 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants