-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Non-production branch builds, GitHub comments and preview URLs #21383
Conversation
Howdy and thanks for contributing to our repo. The Cloudflare team reviews new, external PRs within two (2) weeks. If it's been two weeks or longer without any movement, please tag the PR Assignees in a comment. We review internal PRs within 1 week. If it's something urgent or has been sitting without a comment, start a thread in the Developer Docs space internally. PR Change SummaryDocumented new options for non-production builds, including GitHub comments and preview URLs.
Modified Files
Added Files
How can I customize these reviews?Check out the Hyperlint AI Reviewer docs for more information on how to customize the review. If you just want to ignore it on this PR, you can add the Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add |
3472187
to
8d5b959
Compare
@GregBrimble, adding this to my queue for tomorrow! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Broadly looked over + looks good. Can provide a more detailed review + approval if you need it. Just let me know
Approval, yes please! More detailed review, if you've got the time! Suggestions for any improvements are more than welcome :) |
src/content/docs/workers/ci-cd/builds/git-integration/github-integration.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: Kody Jackson <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great -- thank you Greg!
Summary
Documents the new options for non-production builds. Hold until Monday evening.
Screenshots (optional)
Documentation checklist