Changelog automatic origin key exchange#32225
Conversation
Review
👉 Fix in your agent 👈Fix the following review findings in PR #32225 (https://github.com/cloudflare/cloudflare-docs/pull/32225).
Before making changes, review each finding and present a brief summary table:
- For each finding, state whether you agree, disagree, or need clarification
- If you disagree (e.g. the fix requires disproportionate effort for minimal benefit,
or the finding is factually incorrect), explain why
- If you need clarification before deciding, ask those questions
- Then share your plan for which issues to tackle and in what order
After triaging, follow this order:
1. Post a comment on this PR for any findings you are skipping, with the finding ID and your reasoning.
2. Then commit the fixes for the legitimate findings.
The comment must come before the commit — the bot reads PR comments when a new
push triggers a review, so skip comments posted after the push will be missed.
---
## Code Review
### Warnings (1)
#### CR-1fa822224639 · Technical inaccuracy in cryptographic statement
- **File:** `src/content/changelog/ssl/2026-07-21-automatic-origin-key-exchange.mdx` line 13
- **Issue:** The sentence states 'Cloudflare uses standardized ML-KEM instead of the obsolete `X25519Kyber768Draft00` key agreement.' ML-KEM is a key encapsulation mechanism (KEM), while `X25519Kyber768Draft00` is a hybrid key agreement that combines X25519 and the draft Kyber KEM. Comparing a KEM directly to a hybrid key agreement misrepresents the cryptographic primitive being replaced.
- **Fix:** Replace the statement with an apples-to-apples comparison, for example: 'Cloudflare uses the standardized `X25519MLKEM768` hybrid key agreement instead of the obsolete `X25519Kyber768Draft00` draft key agreement.'
---
## Conventions
### Warnings (2)
#### CV-6114ee28c505 · No meaningful description
- **File:** PR-level finding
- **Issue:** The description contains only the PR template headings and placeholders with no human-written explanation of the change.
- **Fix:** Add a short summary that explains the changelog entry is being added for automatic origin key exchange under SSL.
#### CV-fd67eb29ad4c · Scope not explained
- **File:** PR-level finding
- **Issue:** The PR adds a new changelog file under src/content/changelog/ssl/, but the description says nothing about the new entry.
- **Fix:** Mention that this PR adds a changelog release note for automatic origin key exchange.
Code ReviewThis code review is in beta and may not always be helpful — use your judgment. Warnings (1)
ConventionsWarnings (2)
Style Guide ReviewNo style-guide issues found. CommandsOnly codeowners can run commands. Post a comment with the command to trigger it.
|
| @@ -0,0 +1,26 @@ | |||
| --- | |||
| title: Automatic key exchange reduces origin TLS handshake latency | |||
| description: Cloudflare now selects one zone-wide key agreement from traffic-weighted origin results, reducing retries and using post-quantum encryption when supported. | |||
There was a problem hiding this comment.
... now automatically selects zone-wide preferred key ...
| @@ -0,0 +1,26 @@ | |||
| --- | |||
| title: Automatic key exchange reduces origin TLS handshake latency | |||
| description: Cloudflare now selects one zone-wide key agreement from traffic-weighted origin results, reducing retries and using post-quantum encryption when supported. | |||
There was a problem hiding this comment.
The 'traffic-weighted origin results' bit is more of an implementation detail and doesn't really make a lot of sense here.. maybe this instead?
| description: Cloudflare now selects one zone-wide key agreement from traffic-weighted origin results, reducing retries and using post-quantum encryption when supported. | |
| description: Cloudflare now predicts the key agreement algorithm preferred by origins servers to allow for faster connection establishment. |
| - ssl | ||
| --- | ||
|
|
||
| Cloudflare now automatically selects one zone-wide key agreement for Transport Layer Security (TLS) 1.3 connections to your origins. Cloudflare derives the preference from traffic-weighted results across active origins. Sending the correct key share in the first `ClientHello` avoids a [HelloRetryRequest](https://www.rfc-editor.org/rfc/rfc8446.html#section-4.1.4), removing one network round trip from each new origin connection that would otherwise require a retry. |
There was a problem hiding this comment.
Looks like changelog entries are typically kept pretty brief since they all render on a single page: https://developers.cloudflare.com/changelog/
Perhaps we just state some of the higher-level details and refer to the dev docs? Did something similar here: https://github.com/cloudflare/cloudflare-docs/pull/31540/changes#diff-4f604d1132f43c41a53564b0f8c80495fa529d40a018ff6b9a40b01a69c2e70a
Summary
Screenshots (optional)
Documentation checklist