feat: forward local accept IP to the connection tagger#189
Merged
Conversation
Expose the local IP a connection was accepted on and pass it to the relay's ConnectionTagger, so embedders can classify by inbound interface (e.g. an internal-facing VIP) even on a wildcard/anycast bind. The local port is always our fixed listening port, so only the destination IP the peer targeted is carried. moq-native-ietf: add ConnInfo::local_ip, set from quinn::Connection::local_ip() (the destination IP the establishing datagram arrived on). None when the platform does not expose it. moq-relay-ietf: add ConnectionMeta::local_ip with a with_local_ip() builder and forward ConnInfo::local_ip into ConnectionTagger::tag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose the local IP a connection was accepted on and pass it to the relay's ConnectionTagger, so embedders can classify by inbound interface (e.g. an internal-facing VIP) even on a wildcard/anycast bind. The local port is always our fixed listening port, so only the destination IP the peer targeted is carried.
moq-native-ietf: add ConnInfo::local_ip, set from
quinn::Connection::local_ip() (the destination IP the establishing datagram arrived on). None when the platform does not expose it.
moq-relay-ietf: add ConnectionMeta::local_ip with a with_local_ip() builder and forward ConnInfo::local_ip into ConnectionTagger::tag.