DRAFT: give clear error messages on gateway policy drift #6284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix(migrate): page rules status * chore(resource): migration tests
…te case in R2 bucket resource (cloudflare#6211) * feat: add case-insensitive location handling for R2 bucket resources * handle case-insensitive location comparison and preserve state case in R2 bucket resource
…lures (cloudflare#6222) - Fix workers_script schema: add Computed: true to version_id attribute with default value - Fix worker_version schema: remove WriteOnly: true from jwt attribute under Computed assets - Add missing VersionID field to WorkersScriptMetadataBindingsModel (26→27 attributes) - Fix R2 bucket creation_date refresh drift with UseStateForUnknown() plan modifier - Add locationNormalizePlanModifier for case-insensitive location handling - Update R2 bucket test expectations to match actual case-preservation behavior Resolves schema validation panics in migration tests introduced by commits: - d57ee84 (feat: api update) - 45fef7a (chore: update composite API spec)
… drift (cloudflare#6224) - Add UseStateForUnknown() plan modifiers to created_at/updated_at in zero_trust_access_application schema - Add UseStateForUnknown() plan modifiers to created_at/updated_at/app_count in zero_trust_access_custom_page schema - Change app_count from Optional to Computed in zero_trust_access_custom_page to match API behavior Resolves refresh plan drift where timestamp and count attributes were causing non-empty plans during test refreshes, leading to test failures across the zero trust access test suites. Tests now passing: - TestAccCloudflareAccessApplication_BasicAccount/BasicZone - TestAccCloudflareAccessApplicationDataSource_AccountName - TestAccCloudflareAccessCustomPage_IdentityDenied/Forbidden
…c equivalence check
* fix(api): RAG-286: Add to_markdown subresource to AI resource
…codegen in access_application * chore(zero_trust_access_application): fix config for disabling codegen in access_application
* bug: skip source_url validation if value is missing * chore: add list_item acceptance test for locals validation --------- Co-authored-by: Brad Swenson <[email protected]>
* fix(ai): rename duplicate parameter in the to_markdown subresource
* fix(build): sync SHA for Go SDK dependency with latest commit on 'next' * fix(build): add zero_trust_access_application back
…loudflare#6274) - Modernize all tests to use ConfigStateChecks with statecheck.ExpectKnownValue - Replace legacy resource.ComposeTestCheckFunc patterns with modern testing - Add comprehensive test coverage with 5 new test cases: * Update lifecycle tests (add/remove optional attributes) * Full configuration test covering all deployment bindings * Environment variable type validation (plain_text/secret_text) * Preview deployment setting enum tests (all/none/custom) - Add TestMain and sweeper for automated resource cleanup - Create destroy verification function with proper API integration - Add import verification steps to all test cases - Fix schema access patterns for SingleNestedAttribute fields - Handle API default values with ExpectNonEmptyPlan for refresh plan diffs - Add comprehensive ImportStateVerifyIgnore for computed/sensitive fields - Enable 4 tests to run with default account (44% improvement) - Add modern ConfigPlanChecks for update scenario validation Tests now cover all optional attributes, enum values, lifecycle operations, and deployment binding types with modern Terraform testing patterns.
* TUN-9814: Update virtual network resource * remove acc check
* TUN-9813: Update cloudflared config resource * remove acc check
* fix: fix bot_management and list_item acceptance tests * fix: disable cloudflare_workflow acceptance tests
rexscaria
force-pushed
the
rex/improve-error-reporting-at-gateway-policies
branch
from
dbcb74a to
9cd7488
Compare
stainless-app
bot
force-pushed
the
next
branch
from
49bbfc7 to
618db3c
Compare
rexscaria
force-pushed
the
rex/improve-error-reporting-at-gateway-policies
branch
from
9cd7488 to
502612c
Compare
stainless-app
bot
force-pushed
the
next
branch
from
44843f0 to
057b6a7
Compare
Member
|
@rexscaria do we still need this? might be better to create a new one. |
musa-cf
force-pushed
the
next
branch
2 times, most recently
from
8419486 to
d301974
Compare
stainless-app
bot
force-pushed
the
next
branch
from
4c8915d to
9cc9eee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Going to clean this up so we can provide accurate picture what's drifting in gateway policies. Our customers has been having lot of issues here, this should help