Add logpush_job migrations tests #6456
Closed
+22,493
−1,891
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* chore: point to next
Co-authored-by: yihuaf <[email protected]>
* ci: build migrator v2 in ci * chore: uptake migrator v2 for dns_record
* feat: add terraform config for universal_ssl_setting - Add id_property: zone_id to enable ImportState functionality - Add method: upsert for proper create/update behavior - Configure edit method with explicit type and terraform properties This enables the universal_ssl_setting resource to be fully manageable in Terraform with import support and proper drift detection.
…nes, Streams, Sinks routes * feat(pipelines): Configure SDKs/Terraform to use the new Pipelines, Streams, Sinks routes
ssicard
commented
Nov 12, 2025
Contributor
Author
There was a problem hiding this comment.
Updates are being made in resource.go to account for an update in kind in logpush_job resource. instant-logs was a valid kind option in v4, but is not valid in v5. The API was adding instant-logs back to the state even though it was not valid, so we explicitly ignore that as a value.
… Application (#6453) Adds a new app type for the session duration compatible app types for the zero type access application resource. The newly supported type is proxy_endpoint.
ssicard
requested review from
SirCortly,
musa-cf,
rotem-cloud,
tamas-jozsa and
vaishakdinesh
ssicard
force-pushed
the
ssicard/logpush-job
branch
from
51ed600 to
00a15e7
Compare
musa-cf
force-pushed
the
next
branch
2 times, most recently
from
8419486 to
d301974
Compare
stainless-app
bot
force-pushed
the
next
branch
from
4c8915d to
9cc9eee
Compare
Contributor
Author
|
Closing this PR in favor of #6483 as this got muddled with a lot of other |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds migration tests for the
logpush_jobresource. Below is a more granular listing of all changes:Note: resource.go was updated for this resource to account for less options for kind (no
instant-logssupported)Acceptance test run results
Additional context & links