EW-9753 Enable deprecation warnings for attaching to refcounted objects #5513
+12
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
- This includes making TailStreamWriter non-refcounted.
fhanau
force-pushed
the
felix/EW-9753
branch
from
2f230de to
8af2aab
Compare
fhanau
commented
Nov 24, 2025
| TRACE_EVENT("workerd", "WorkerEntrypoint::init() create new IoContext"); | ||
| auto actorRef = actor.map([](kj::Own<Worker::Actor>& ptr) -> Worker::Actor& { return *ptr; }); | ||
|
|
||
| // TODO: Does this refcounted instane always live long enough for ioContextDependency here? |
Contributor
Author
There was a problem hiding this comment.
Still need to figure this one out
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.