Improve error message in Response ctor when webSocket not specified. #5532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something I ran into and found confusing. If you attempt to construct a Response with status code 101 and fail to pass in a web socket to the constructor you'll be met with a "Responses may only be constructed with status codes in the range 200 to 599, inclusive". Which implies that constructing a Response with a status code of 101 is not allowed.
Looks like others found it confusing too:
https://community.cloudflare.com/t/cant-return-status-101-for-websocket/428883
This simple change should make this a little bit more user friendly.