Skip to content

Remove some dead code #5594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 26, 2025
Merged

Remove some dead code #5594

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/workerd/jsg/iterator.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -531,8 +531,6 @@ class SequenceWrapper {
// TypeWrapper mixin for Sequences.

public:
static auto constexpr MAX_STACK = 64;

template <typename U>
static constexpr const char* getName(Sequence<U>*) {
// TODO(later): It would be nicer if the name included the demangled name of U
Expand Down
12 changes: 0 additions & 12 deletions src/workerd/jsg/value.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -538,16 +538,6 @@ class StringWrapper {
// =======================================================================================
// Optional (value or undefined) and Maybe (value or null)

template <typename... T>
constexpr bool isUnionType(kj::OneOf<T...>*) {
return true;
}

template <typename T>
constexpr bool isUnionType(T*) {
return false;
}

// TypeWrapper mixin for optionals.
template <typename TypeWrapper>
class OptionalWrapper {
Expand Down Expand Up @@ -842,7 +832,6 @@ class OneOfWrapper {
template <typename TypeWrapper>
class ArrayWrapper {
public:
static auto constexpr MAX_STACK = 64;
template <typename U>
static constexpr const char* getName(kj::Array<U>*) {
return "Array";
Expand Down Expand Up @@ -917,7 +906,6 @@ class ArrayWrapper {
template <typename TypeWrapper>
class SetWrapper {
public:
static auto constexpr MAX_STACK = 64;
template <typename U>
static constexpr const char* getName(kj::HashSet<U>*) {
return "Set";
Expand Down