Skip to content

remove skipLastDeployedFromApiCheck from deploy helpers#14399

Merged
emily-shen merged 2 commits into
mainfrom
emily/remove-skip-hack
Jun 26, 2026
Merged

remove skipLastDeployedFromApiCheck from deploy helpers#14399
emily-shen merged 2 commits into
mainfrom
emily/remove-skip-hack

Conversation

@emily-shen

@emily-shen emily-shen commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

this was a temporary thing for cf, now have fixed this API side, should be in the next EWC release.


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because: removing something temporary
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: removing something temporary

A picture of a cute animal (not mandatory, but encouraged)


Open in Devin Review

@changeset-bot

changeset-bot Bot commented Jun 23, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 133784c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudflare/deploy-helpers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-project-automation github-project-automation Bot moved this to Untriaged in workers-sdk Jun 23, 2026
@workers-devprod workers-devprod requested review from a team and dario-piotrowicz and removed request for a team June 23, 2026 16:24
@workers-devprod

workers-devprod commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Codeowners approval required for this PR:

  • ✅ @cloudflare/wrangler
Show detailed file reviewers

@github-actions

Copy link
Copy Markdown
Contributor

✅ All changesets look good

@ask-bonk

ask-bonk Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

All the type usages are consistent. The only place that set the property was merge-config-args.ts which is updated in this PR. The removal is complete and consistent across the type definition, both consumers (deploy.ts and versions-upload.ts), and the single producer.

The changeset is correctly scoped to @cloudflare/deploy-helpers. Note the changeset bot suggested also bumping wrangler (since merge-config-args.ts is in wrangler), but that change is purely internal (removing a prop that was always false), so no user-facing wrangler change—a deploy-helpers-only changeset is appropriate.

The change is a clean, complete removal of a temporary option with no dangling references or behavioral surprises.

LGTM

github run

devin-ai-integration[bot]

This comment was marked as resolved.

@pkg-pr-new

pkg-pr-new Bot commented Jun 23, 2026

Copy link
Copy Markdown
@cloudflare/autoconfig

npm i https://pkg.pr.new/@cloudflare/autoconfig@14399

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@14399

@cloudflare/deploy-helpers

npm i https://pkg.pr.new/@cloudflare/deploy-helpers@14399

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@14399

miniflare

npm i https://pkg.pr.new/miniflare@14399

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@14399

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@14399

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@14399

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@14399

@cloudflare/workers-auth

npm i https://pkg.pr.new/@cloudflare/workers-auth@14399

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@14399

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@14399

wrangler

npm i https://pkg.pr.new/wrangler@14399

commit: 133784c

@workers-devprod workers-devprod left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeowners reviews satisfied

@github-project-automation github-project-automation Bot moved this from Untriaged to Approved in workers-sdk Jun 25, 2026
@emily-shen emily-shen force-pushed the emily/remove-skip-hack branch from 3578b59 to 4a79070 Compare June 26, 2026 12:38
@emily-shen emily-shen enabled auto-merge (squash) June 26, 2026 16:31
@emily-shen emily-shen merged commit 9ed7779 into main Jun 26, 2026
64 of 65 checks passed
@emily-shen emily-shen deleted the emily/remove-skip-hack branch June 26, 2026 16:58
@github-project-automation github-project-automation Bot moved this from Approved to Done in workers-sdk Jun 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants