Remove loopback for Router worker#14418
Conversation
🦋 Changeset detectedLatest commit: 716cfd9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
workers-devprod
requested review from
a team and
NuroDev
and removed request for
a team
|
Codeowners approval required for this PR:
Show detailed file reviewers
|
|
✅ All changesets look good |
|
The behavior of The change is clean: the default export now points to the inner entrypoint directly (bypassing loopback), and the outer entrypoint remains exported for re-enabling later. The miniflare and vite re-export files correctly add No logic bugs, security issues, backward-compat violations, or incorrect API behavior found. The trailing-comma changes are formatting (out of scope). LGTM |
@cloudflare/autoconfig
create-cloudflare
@cloudflare/deploy-helpers
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-auth
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
matthewdavidrodgers
force-pushed
the
router-worker-outer-entrypoint-class
branch
from
fb1c0da to
c77b71f
Compare
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| Bypass the router Worker loopback on the normal request path | ||
|
|
||
| The inner routing entrypoint is now the default, avoiding the latency added by forwarding every request through `ctx.exports`. The outer loopback entrypoint and its supporting infrastructure remain available as named exports in the router Worker, Miniflare, and Vite plugin bundles so the boundary can be re-enabled later. |
There was a problem hiding this comment.
🟡 Changeset description contains implementation details instead of user-facing impact
REVIEW.md states: "Changesets should target users of the tools (e.g. Wrangler users) rather than maintainers. Avoid including implementation details like 'moves X from hybridModules to nativeModules' or 'removes polyfill implementation' or 'adds comprehensive tests'. Instead, focus on user-facing impact and benefits." The changeset title "Bypass the router Worker loopback on the normal request path" and body mentioning "inner routing entrypoint", "ctx.exports", "outer loopback entrypoint", and "named exports in the router Worker, Miniflare, and Vite plugin bundles" are all implementation details. The user-facing benefit (reduced latency / improved performance) should be the focus instead.
| Bypass the router Worker loopback on the normal request path | |
| The inner routing entrypoint is now the default, avoiding the latency added by forwarding every request through `ctx.exports`. The outer loopback entrypoint and its supporting infrastructure remain available as named exports in the router Worker, Miniflare, and Vite plugin bundles so the boundary can be re-enabled later. | |
| Improve routing performance for Workers with assets | |
| Reduce request handling latency by streamlining the router Worker's request path. The loopback infrastructure remains available for future use. | |
Was this helpful? React with 👍 or 👎 to provide feedback.
NuroDev
left a comment
NuroDev
left a comment
There was a problem hiding this comment.
LGTM apart from Devin's comment on the changeset description
matthewdavidrodgers
force-pushed
the
router-worker-outer-entrypoint-class
branch
from
c77b71f to
716cfd9
Compare
workers-devprod
left a comment
workers-devprod
left a comment
There was a problem hiding this comment.
Codeowners reviews satisfied
4 participants
Fixes WC-5346.
Bypass the router Worker loopback on the normal request path
The inner routing entrypoint is now the default, avoiding the latency added by forwarding every request through
ctx.exports. The outer loopback entrypoint and its supporting infrastructure remain available as named exports in the router Worker, Miniflare, and Vite plugin bundles so the boundary can be re-enabled later.A picture of a cute animal (not mandatory, but encouraged)