Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/miniflare/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
"@cspotcode/source-map-support": "0.8.1",
"sharp": "0.34.5",
"undici": "catalog:default",
"workerd": "1.20260625.1",
"workerd": "1.20260626.1",
"ws": "catalog:default",
"youch": "4.1.0-beta.10"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/wrangler/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@
"miniflare": "workspace:*",
"path-to-regexp": "6.3.0",
"unenv": "2.0.0-rc.24",
"workerd": "1.20260625.1"
"workerd": "1.20260626.1"
},
"devDependencies": {
"@aws-sdk/client-s3": "^3.721.0",
Expand Down
46 changes: 23 additions & 23 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pnpm-workspace.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ catalog:
"@playwright/test": "1.60.0"
playwright-chromium: "1.60.0"
"@cloudflare/workers-types": "^4.20260625.1"
workerd: "1.20260625.1"
workerd: "1.20260626.1"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Lockfile not updated after dependency version bump, causing install failures

The lockfile still resolves the old version (specifier: 1.20260625.1 in pnpm-lock.yaml) after the declared version was bumped (pnpm-workspace.yaml:123), so pnpm install --frozen-lockfile in CI will fail due to the specifier mismatch.

Impact: CI builds will fail, or users will silently get the wrong runtime version installed.

Lockfile specifiers are stale after catalog version change

The catalog in pnpm-workspace.yaml:123 was updated from workerd: "1.20260625.1" to workerd: "1.20260626.1", and packages/miniflare/package.json:55 and packages/wrangler/package.json:87 were also updated. However, the pnpm-lock.yaml still contains specifier: 1.20260625.1 for both miniflare and wrangler's workerd dependency, and there are zero references to 20260626 anywhere in the lockfile. The lockfile diff only contains unrelated changes (vitest resolution shuffles, bson version bump).

Per AGENTS.md: "After updating dependencies, always run pnpm i to also update the package lock file." This was not done for the workerd bump, so the lockfile is out of sync with the workspace configuration.

Prompt for agents
The pnpm-lock.yaml was not updated to reflect the workerd version bump from 1.20260625.1 to 1.20260626.1. The lockfile still references the old version (specifier: 1.20260625.1) in two places (miniflare and wrangler importers). Run `pnpm install` (or `pnpm i`) in the repository root to regenerate the lockfile with the correct workerd version, then commit the updated pnpm-lock.yaml.
Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

jsonc-parser: "3.2.0"
smol-toml: "1.5.2"
msw: 2.12.4
Expand Down
Loading