Skip to content

[vitest-plugin] Stabilize Vite mode config test - #15338

Merged
edmundhung merged 2 commits into
mainfrom
edmundhung/stabilize-vitest-mode-test
Aug 24, 2026
Merged

[vitest-plugin] Stabilize Vite mode config test#15338
edmundhung merged 2 commits into
mainfrom
edmundhung/stabilize-vitest-mode-test

Conversation

@edmundhung

@edmundhung edmundhung commented Aug 24, 2026

Copy link
Copy Markdown
Member

Split the Vite mode configuration test into two independent tests: one covering the default test mode and one covering an explicit --mode=staging override.

The original test launched Vitest twice under a single 15-second timeout and had started timing out on loaded Linux and macOS CI runners. Each new test launches Vitest once and retains the package's default timeout.


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: This only reorganizes an internal test.

A picture of a cute animal (not mandatory, but encouraged)

@changeset-bot

changeset-bot Bot commented Aug 24, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: ef93280

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-project-automation github-project-automation Bot moved this to Untriaged in workers-sdk Aug 24, 2026
@workers-devprod
workers-devprod requested review from a team and NuroDev and removed request for a team August 24, 2026 17:17
@workers-devprod

workers-devprod commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Codeowners approval required for this PR:

  • ✅ @cloudflare/wrangler
Show detailed file reviewers

@edmundhung edmundhung added the ci:no-changeset-required Skip pull request checks for a valid changeset label Aug 24, 2026
@ask-bonk

ask-bonk Bot commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

github run

@ask-bonk

ask-bonk Bot commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

@edmundhung Bonk workflow failed. Check the logs for details.

View workflow run · To retry, trigger Bonk again.

@pkg-pr-new

pkg-pr-new Bot commented Aug 24, 2026

Copy link
Copy Markdown
@cloudflare/autoconfig

npm i https://pkg.pr.new/@cloudflare/autoconfig@15338

@cloudflare/build-output-utils

npm i https://pkg.pr.new/@cloudflare/build-output-utils@15338

@cloudflare/codemods

npm i https://pkg.pr.new/@cloudflare/codemods@15338

@cloudflare/config

npm i https://pkg.pr.new/@cloudflare/config@15338

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@15338

@cloudflare/deploy-helpers

npm i https://pkg.pr.new/@cloudflare/deploy-helpers@15338

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@15338

miniflare

npm i https://pkg.pr.new/miniflare@15338

@cloudflare/pages-functions

npm i https://pkg.pr.new/@cloudflare/pages-functions@15338

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@15338

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@15338

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@15338

@cloudflare/vitest-plugin

npm i https://pkg.pr.new/@cloudflare/vitest-plugin@15338

@cloudflare/workers-auth

npm i https://pkg.pr.new/@cloudflare/workers-auth@15338

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@15338

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@15338

wrangler

npm i https://pkg.pr.new/wrangler@15338

commit: ef93280

@workers-devprod workers-devprod left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeowners reviews satisfied

@github-project-automation github-project-automation Bot moved this from Untriaged to Approved in workers-sdk Aug 24, 2026
@edmundhung
edmundhung enabled auto-merge (squash) August 24, 2026 17:41
@edmundhung
edmundhung merged commit 2624bca into main Aug 24, 2026
71 of 75 checks passed
@edmundhung
edmundhung deleted the edmundhung/stabilize-vitest-mode-test branch August 24, 2026 18:41
@github-project-automation github-project-automation Bot moved this from Approved to Done in workers-sdk Aug 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:no-changeset-required Skip pull request checks for a valid changeset

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants