Skip to content

[wrangler] Stabilize remote bindings E2E on Windows - #15339

Merged
edmundhung merged 1 commit into
mainfrom
edmundhung/fix-remote-binding-e2e-stale-registry
Aug 24, 2026
Merged

[wrangler] Stabilize remote bindings E2E on Windows#15339
edmundhung merged 1 commit into
mainfrom
edmundhung/fix-remote-binding-e2e-stale-registry

Conversation

@edmundhung

Copy link
Copy Markdown
Member

Fixes the recurring Windows Wrangler E2E failure demonstrated in run 32764326302.

The remote bindings suite started several local Worker processes with the same dev-registry name, local-worker. Windows test cleanup force-terminates each process, which can leave its registry entry present for the 90-second stale window. Later tests and all immediate retries then resolve the local service binding to the dead process's debug port and fail with Network connection lost.

Generate a unique name for each local Worker process and use it in the corresponding service binding. Also avoid starting local Workers in the two tests that do not configure a local binding.


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: this only stabilizes an internal E2E test.

A picture of a cute animal (not mandatory, but encouraged)

@changeset-bot

changeset-bot Bot commented Aug 24, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 58684c3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ask-bonk

ask-bonk Bot commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

APIError: Invalid Anthropic API Key

github run

@ask-bonk

ask-bonk Bot commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

@edmundhung Bonk workflow failed. Check the logs for details.

View workflow run · To retry, trigger Bonk again.

@pkg-pr-new

pkg-pr-new Bot commented Aug 24, 2026

Copy link
Copy Markdown
@cloudflare/autoconfig

npm i https://pkg.pr.new/@cloudflare/autoconfig@15339

@cloudflare/build-output-utils

npm i https://pkg.pr.new/@cloudflare/build-output-utils@15339

@cloudflare/codemods

npm i https://pkg.pr.new/@cloudflare/codemods@15339

@cloudflare/config

npm i https://pkg.pr.new/@cloudflare/config@15339

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@15339

@cloudflare/deploy-helpers

npm i https://pkg.pr.new/@cloudflare/deploy-helpers@15339

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@15339

miniflare

npm i https://pkg.pr.new/miniflare@15339

@cloudflare/pages-functions

npm i https://pkg.pr.new/@cloudflare/pages-functions@15339

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@15339

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@15339

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@15339

@cloudflare/vitest-plugin

npm i https://pkg.pr.new/@cloudflare/vitest-plugin@15339

@cloudflare/workers-auth

npm i https://pkg.pr.new/@cloudflare/workers-auth@15339

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@15339

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@15339

wrangler

npm i https://pkg.pr.new/wrangler@15339

commit: 58684c3

@edmundhung edmundhung added the ci:run-remote-tests Run remote/E2E tests that require Cloudflare API credentials label Aug 24, 2026
@edmundhung

Copy link
Copy Markdown
Member Author

CI verification: the credentialed Wrangler E2E matrix passed on every OS and shard. In the previously affected Windows shard 3 job, all seven dev-remote-bindings tests passed on their first attempt with no 'Network connection lost' failures: https://github.com/cloudflare/workers-sdk/actions/runs/32772056797/job/97577909576. The separate Windows packages-and-tools failure is in legacy-assets.test.ts (a timeout plus its cascading stdout snapshot mismatch) and does not exercise this E2E file.

@edmundhung
edmundhung marked this pull request as ready for review August 24, 2026 21:00
@workers-devprod
workers-devprod requested review from a team and jamesopstad and removed request for a team August 24, 2026 21:01
@workers-devprod

workers-devprod commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Codeowners approval required for this PR:

  • ✅ @cloudflare/wrangler
Show detailed file reviewers

@edmundhung edmundhung added the ci:no-changeset-required Skip pull request checks for a valid changeset label Aug 24, 2026

@workers-devprod workers-devprod left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeowners reviews satisfied

@github-project-automation github-project-automation Bot moved this from Untriaged to Approved in workers-sdk Aug 24, 2026
@edmundhung
edmundhung merged commit 296a1a7 into main Aug 24, 2026
105 of 113 checks passed
@edmundhung
edmundhung deleted the edmundhung/fix-remote-binding-e2e-stale-registry branch August 24, 2026 22:05
@github-project-automation github-project-automation Bot moved this from Approved to Done in workers-sdk Aug 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:no-changeset-required Skip pull request checks for a valid changeset ci:run-remote-tests Run remote/E2E tests that require Cloudflare API credentials

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants