[wrangler] Stabilize remote bindings E2E on Windows - #15339
Conversation
|
|
APIError: Invalid Anthropic API Key |
|
@edmundhung Bonk workflow failed. Check the logs for details. View workflow run · To retry, trigger Bonk again. |
@cloudflare/autoconfig
@cloudflare/build-output-utils
@cloudflare/codemods
@cloudflare/config
create-cloudflare
@cloudflare/deploy-helpers
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-functions
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-plugin
@cloudflare/workers-auth
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
|
CI verification: the credentialed Wrangler E2E matrix passed on every OS and shard. In the previously affected Windows shard 3 job, all seven dev-remote-bindings tests passed on their first attempt with no 'Network connection lost' failures: https://github.com/cloudflare/workers-sdk/actions/runs/32772056797/job/97577909576. The separate Windows packages-and-tools failure is in legacy-assets.test.ts (a timeout plus its cascading stdout snapshot mismatch) and does not exercise this E2E file. |
|
Codeowners approval required for this PR:
Show detailed file reviewers |
workers-devprod
left a comment
There was a problem hiding this comment.
Codeowners reviews satisfied
Fixes the recurring Windows Wrangler E2E failure demonstrated in run 32764326302.
The remote bindings suite started several local Worker processes with the same dev-registry name,
local-worker. Windows test cleanup force-terminates each process, which can leave its registry entry present for the 90-second stale window. Later tests and all immediate retries then resolve the local service binding to the dead process's debug port and fail withNetwork connection lost.Generate a unique name for each local Worker process and use it in the corresponding service binding. Also avoid starting local Workers in the two tests that do not configure a local binding.
A picture of a cute animal (not mandatory, but encouraged)