WIP: Canary steps #4219
Open
WIP: Canary steps #4219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethboyles
reviewed
Feb 14, 2025
| up do | ||
| alter_table(:deployments) do | ||
| # TODO: what size? | ||
| add_column :canary_steps, String, size: 4096 |
There was a problem hiding this comment.
thought: Should this be a JSON column for Postgres?
Samze
commented
Feb 14, 2025
| @@ -99,6 +114,27 @@ def continuable? | |||
| state == DeploymentModel::PAUSED_STATE | |||
| end | |||
|
|
|||
| def canary_step | |||
| raise 'canary_step is only valid for canary deloyments' unless strategy == CANARY_STRATEGY | |||
There was a problem hiding this comment.
note Calling this is a programming error so seemed best to raise an exception.
Samze
commented
Feb 14, 2025
|
|
||
| unless canary_steps.nil? | ||
| # ensure that canary steps are in the correct format for serialization | ||
| self.canary_steps = canary_steps.map(&:stringify_keys) |
There was a problem hiding this comment.
todo See if we can remove this check.
Samze
commented
Feb 14, 2025
| @@ -86,6 +90,17 @@ def before_update | |||
| super | |||
| set_status_updated_at | |||
| end | |||
| # TODO: documentation | |||
There was a problem hiding this comment.
todo remove this comment, documentation is done.
sethboyles
force-pushed
the
canary_steps
branch
from
5fe71c8 to
c7029d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to cloud_controller_ng. To speed up the process of reviewing your pull request please provide us with:
A short explanation of the proposed change:
An explanation of the use cases your change solves
Links to any other associated PRs
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests