Skip to content

fix(cluster): critical reliability and templating fixes#827

Open
philippemnoel wants to merge 1 commit into
cloudnative-pg:mainfrom
paradedb:phil/critical-reliability-fixes
Open

fix(cluster): critical reliability and templating fixes#827
philippemnoel wants to merge 1 commit into
cloudnative-pg:mainfrom
paradedb:phil/critical-reliability-fixes

Conversation

@philippemnoel
Copy link
Copy Markdown
Contributor

@philippemnoel philippemnoel commented Mar 5, 2026

I caught these while working on the @paradedb fork. Figured these changes would benefit upstream and reduce our diff:

  • Fix endpointCA in barman object store template: use coalesce/default so it falls back to the generated CA bundle name and default key when only .endpointCA.create is set without explicit .name/.key
  • Fix databases.yaml templating:
    • Default database owner to the database name when .owner is not specified
    • Use hasKey instead of with for isTemplate, allowConnections, and connectionLimit so that false/0 values are correctly rendered instead of silently skipped
    • Default schema owner to the database owner when not explicitly set

(The originally proposed PID comparison fix in the logical replication stopped alerts was superseded by #868, which landed an equivalent == 0 fix while this PR was open.)

Enjoy!

@dosubot dosubot Bot added size:S This PR changes 10-29 lines, ignoring generated files. bug Something isn't working chart( cluster ) Related to the cluster chart labels Mar 5, 2026
@philippemnoel philippemnoel force-pushed the phil/critical-reliability-fixes branch from d35d736 to 0ccb248 Compare March 5, 2026 20:51
Signed-off-by: Philippe Noël <philippemnoel@gmail.com>
@philippemnoel philippemnoel force-pushed the phil/critical-reliability-fixes branch from 0ccb248 to 64a568e Compare May 18, 2026 04:37
@dosubot dosubot Bot added size:XS This PR changes 0-9 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels May 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working chart( cluster ) Related to the cluster chart size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant