feat: new extension scaffolding #79
Merged
+364
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GabriFedi97
force-pushed
the
dev/17
branch
4 times, most recently
from
48283c4 to
3349043
Compare
gbartolini
reviewed
Jan 20, 2026
mbiagetti
approved these changes
Jan 20, 2026
Contributor
mbiagetti
left a comment
mbiagetti
left a comment
There was a problem hiding this comment.
I've tested the command and do the job.
Don't know if we should also patch some wf like:
-
add the name
postgres-extensions-containers/.github/workflows/bake.yml
Lines 10 to 13 in 9d8ef22
-
add a new section
postgres-extensions-containers/.github/workflows/bake.yml
Lines 52 to 54 in 9d8ef22
Contributor
Author
That's a good point, but I'd keep it out of this PR. We can also think about some sort of required check to ensure tests have run on every modified target/extension |
Contributor
@GabriFedi97 Agree, is a bit out-of-scope for the scaffolding task 👍 |
Signed-off-by: Gabriele Fedi <[email protected]>
Signed-off-by: Gabriele Fedi <[email protected]>
Signed-off-by: Gabriele Fedi <[email protected]>
Signed-off-by: Gabriele Fedi <[email protected]>
Signed-off-by: Gabriele Fedi <[email protected]>
Signed-off-by: Gabriele Bartolini <[email protected]>
Added copyright info Signed-off-by: Gabriele Bartolini <[email protected]>
Signed-off-by: Gabriele Bartolini <[email protected]>
Signed-off-by: Gabriele Bartolini <[email protected]>
Signed-off-by: Gabriele Fedi <[email protected]>
Signed-off-by: Gabriele Bartolini <[email protected]>
Signed-off-by: Niccolò Fei <[email protected]>
NiccoloFei
approved these changes
Jan 22, 2026
Add validation for name, versions, distros parameters and template file existence. Extension names must contain only lowercase alphanumeric characters, hyphens, and underscores. Signed-off-by: Marco Nenciarini <[email protected]>
Enhance error messages to include template file name and context, making it easier to debug template-related failures. Signed-off-by: Marco Nenciarini <[email protected]>
Replace vector-specific example text with generic placeholders that developers should customize for their extensions. Signed-off-by: Marco Nenciarini <[email protected]>
Replace unconventional <REMOVE> blocks with standard TODO comments for better readability and consistency with common practices. Signed-off-by: Marco Nenciarini <[email protected]>
Add precondition to check NAME is not empty and improve error messages with usage examples. Add description to NAME variable requirement. Signed-off-by: Marco Nenciarini <[email protected]>
mnencia
approved these changes
Jan 22, 2026
gbartolini
reviewed
Jan 22, 2026
| # Include the extension's shared objects and related dependencies under the /lib directory. | ||
| # CNPG will load these libraries at runtime by configuring the dynamic linker path (LD_LIBRARY_PATH) and | ||
| # the PostgreSQL GUC "dynamic_library_path" based on defaults and Cluster configuration. | ||
| # CNPG will configure PostgreSQL to locate these libraries at runtime by configuring |
gbartolini
approved these changes
Jan 22, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Dagger function and Taskfile entry to scaffold a new extension directory from scratch.
Documentation has been temporarily added to the
BUILD.mdfile but will probably be moved in a more appropriate section.Closes #17