Add event rule pattern detail and control finding generator variable - #59
Open
Alex Boyd (aaboyd) wants to merge 4 commits into
Open
Add event rule pattern detail and control finding generator variable#59Alex Boyd (aaboyd) wants to merge 4 commits into
Alex Boyd (aaboyd) wants to merge 4 commits into
Conversation
Alex Boyd (aaboyd)
requested review from
Hans Donner (hans-d) and
John C. Bland II (johncblandii)
April 22, 2024 02:55
|
Any chance we can get this prioritized / merged? Looking for this feature now, as enabling the default SNS with the module sends too many alerts |
| check applies to multiple enabled standards. | ||
| DOC | ||
| type = string | ||
| default = "SECURITY_CONTROL" |
Member
There was a problem hiding this comment.
It would be nice to add a validation block here to check if the values inputted are correct
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what
Add two variables for better customization of the module.
why
cloudwatch_event_rule_pattern_detail- allow a more specific detail pattern in order to filter events sent through the SNS topic. Currently using to only match events which have failed and are 'HIGH' and 'CRITICAL'.control_finding_generator- optionality that exists onaws_securityhub_account. Ensures that users of this module don't sacrifice functionality.