fix(volo-thrift): clean waiters while failed waiting for idle connection #547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Millione
force-pushed
the
fix-waiters-memory-leak
branch
from
a917f11 to
570a9f6
Compare
PureWhiteWu
reviewed
Feb 5, 2025
PureWhiteWu
reviewed
Feb 5, 2025
Millione
force-pushed
the
fix-waiters-memory-leak
branch
from
570a9f6 to
c2d293f
Compare
PureWhiteWu
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the previous implementation of the connection pool , if there is no connection available at all, the tx in the waiter list will keep be inserted and never be cleared, resulting in memory leaks.
This PR solves this problem by clearing the corresponding tx in the waiting queue when rx drops.