Skip to content

fix typo in example code #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 13, 2024
Merged

Conversation

GhostPirateBob
Copy link
Contributor

@GhostPirateBob GhostPirateBob commented Jul 11, 2024

fix $temperature->getFormatteed in example code
fix percipitation in docs

Hi @cmfcmf, I'm kind of glad I found this typo because it gives me a chance to leave a comment and say thanks for the great job with this repo!

It was delightful to use the Unit class. Makes me regret writing my own implementation the last few times.

Anyways, hope I've filed this in the right way for contributions, it's just a tiny typo in the example code. The actual code in the repo is correct and doesn't need to change.

2024-07-11 17_18_32-Usage _ OpenWeatherMap PHP API - Thorium

Keep up the great work, thanks!

gpb. ✌(◕‿-)✌

Copy link

codecov bot commented Jul 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.33%. Comparing base (2ffe2c7) to head (8dfe070).

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #193   +/-   ##
=========================================
  Coverage     90.33%   90.33%           
  Complexity      179      179           
=========================================
  Files            18       18           
  Lines           414      414           
=========================================
  Hits            374      374           
  Misses           40       40           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmfcmf
Copy link
Owner

cmfcmf commented Jul 13, 2024

Thanks a lot!

@cmfcmf cmfcmf merged commit 17b537b into cmfcmf:main Jul 13, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants