Set RankingWebServer listen address to "" in sample config

[prandla]

This matches the defaults in cms.conf.sample. In particular, this is useful because when using cms-dev.sh, the default config leaves RWS listening at 127.0.0.1, which is not accessible outside docker, even though docker-compose.dev.yml specifically exposes port 8890 for it.

Also, I changed AWS from 0.0.0.0 to "". "" seems to listen on both ipv6 and ipv4, as opposed to 0.0.0.0 which is ipv4 only, so it feels like a slightly better choice here.

[veluca93]

I'm not sure this is a great idea... I think I'd like having everything listen on 127.0.0.1 by default, and have cms-dev.sh use nginx or similar to expose things, would be better.

[prandla]

Well, the thing is, if the listen address is 127.0.0.1 then that port cannot be accessed from outside docker. so we would either need to use docker's host networking mode (which I don't like, because then all the cms internal services along with postgres also get exposed on your localhost) or rewrite all the ips inside our Dockerfile, similar to what we do for the database connection string.

...I guess the latter isn't too bad actually.

[prandla]

also, i don't like the idea of using nginx for cms-dev.sh, i don't think it provides any benefit really. (and suffers from the exact same problem: what address do you set nginx to listen on? if you set it to listen on 0.0.0.0 and forward all requests to cms, then it's identical to just having cms itself listen on 0.0.0.0)

[veluca93]

also, i don't like the idea of using nginx for cms-dev.sh, i don't think it provides any benefit really. (and suffers from the exact same problem: what address do you set nginx to listen on? if you set it to listen on 0.0.0.0 and forward all requests to cms, then it's identical to just having cms itself listen on 0.0.0.0)

I agree it is identical. However, doing so makes the default configuration not expose rws/aws to everyone, which is IMO valuable.

[prandla]

In that case i'll just implement the rewrites in Dockerfile.