Optimize some unit tests#1405
Merged
Merged
Conversation
veluca93
approved these changes
Jun 10, 2025
veluca93
reviewed
Jun 10, 2025
* Some tests end up having to hash passwords. Add a tweak that allows setting the hashing difficulty to a lower value for the tests. * file_middleware_test had a really inefficient setUp() method, which matters more now that the FileCacher block size is 1MB.
prandla
force-pushed
the
unit-test-optimization
branch
from
05c0bf6 to
4713255
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should save around 10 seconds in CI (according to codecov test timings).