Skip to content

Add beginRun and beginLuminosityBlock to moduleAllocMonitors diff table.#2696

Open
gartung wants to merge 2 commits intocms-sw:masterfrom
gartung:gartung-moduleallocmon-diff-update
Open

Add beginRun and beginLuminosityBlock to moduleAllocMonitors diff table.#2696
gartung wants to merge 2 commits intocms-sw:masterfrom
gartung:gartung-moduleallocmon-diff-update

Conversation

@gartung
Copy link
Member

@gartung gartung commented Mar 5, 2026

No description provided.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2026

A new Pull Request was created by @gartung for branch master.

@akritkbehera, @cmsbuild, @iarspider, @raoatifshad, @smuzaffar can you please review it and eventually sign? Thanks.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2026

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2026

Pull request #2696 was updated.

@gartung
Copy link
Member Author

gartung commented Mar 5, 2026

test parameters:

enable = profiling
workflows_profiling = 18634.21

@gartung
Copy link
Member Author

gartung commented Mar 5, 2026

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2026

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1c4b14/51789/summary.html
COMMIT: 065afe7
CMSSW: CMSSW_16_1_X_2026-03-05-1100/el8_amd64_gcc13
Additional Tests: PROFILING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cms-bot/2696/51789/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 16 differences found in the comparisons
  • DQMHistoTests: Total files compared: 53
  • DQMHistoTests: Total histograms compared: 4180442
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4180413
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
  • Checked 227 log files, 198 edm output root files, 53 DQM output files
  • TriggerResults: no differences found

@gartung
Copy link
Member Author

gartung commented Mar 5, 2026

@makortel This is ready for review and suggestions.

@makortel
Copy link
Contributor

makortel commented Mar 5, 2026

Looks good for this iteration. I have some ideas for further improvements, but I have a feeling they would require some interactivity with e.g. JavaScript, and thus I'd like to discuss those first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Include beginRun and beginLumi in ModuleAllocMonitor diff tables in profiling PR tests

3 participants