2129 fix hrr for nssp #2131
Merged
2129 fix hrr for nssp #2131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aysim319
commented
Mar 3, 2025
melange396
reviewed
Mar 3, 2025
melange396
previously requested changes
Mar 3, 2025
aysim319
dismissed
melange396’s stale review
applied requested changes and want to see how the build runs (currently blocked by pending request)
melange396
reviewed
Mar 5, 2025
Contributor
melange396
left a comment
melange396
left a comment
There was a problem hiding this comment.
the logic in the elif geo == "hrr": section looks good... can you describe whats going on with the changes to tests and with the txt/json files?
minhkhul
approved these changes
Mar 11, 2025
Contributor
minhkhul
left a comment
minhkhul
left a comment
There was a problem hiding this comment.
lgtm! Appreciate the addition of full run module tests.
[nonblocking] suggesting some extra docstrings for clarity.
Co-authored-by: minhkhul <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
cleaning up test and fixing geo aggregation for hrr
Associated Issue(s)