fix unittest.mock import error #1574
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was referenced Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CI build is currently broken by an import error, but this PR includes a simple fix.
Last successful build:
https://github.com/cmu-delphi/delphi-epidata/actions/runs/12265958980/job/34223121686
Dec 10, 2024
runner image
ubuntu-22.04version20241201.1.0First failing build:
https://github.com/cmu-delphi/delphi-epidata/actions/runs/12635938712/job/35206910938
Jan 6, 2025
runner image
ubuntu-24.04version20241215.1.0I'm guessing that these version changes are the cause of the error. I would have thought that we would be protected from such problems since the tests run inside docker. (Maybe it does protect us? Which would then mean that something else is the cause...)
Going from ubuntu 22 to ubuntu 24 is kind of a big step to happen without warning... Do we want to consider changing to running on a specific image version instead of "latest"?
delphi-epidata/.github/workflows/ci.yaml
Line 6 in 827be44