NHSN doc changes #1601
Merged
NHSN doc changes #1601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmdefries
previously approved these changes
Feb 19, 2025
Contributor
nmdefries
left a comment
nmdefries
left a comment
There was a problem hiding this comment.
Please check the wording changes I made. After those are included, this is good to go.
Co-authored-by: nmdefries <[email protected]>
Co-authored-by: nmdefries <[email protected]>
melange396
requested changes
Feb 19, 2025
Co-authored-by: george <[email protected]>
Contributor
Author
|
@carlynvandyke thanks for catching my numerous copy pastas 😅 hopefully i fixed it this time around |
melange396
reviewed
Feb 24, 2025
melange396
previously approved these changes
Feb 24, 2025
Collaborator
melange396
left a comment
melange396
left a comment
There was a problem hiding this comment.
you could fix some of the spacing to make the table line up better in the raw file, but it doesnt affect the rendered version. otherwise, it looks good to me!
Co-authored-by: george <[email protected]>
|
melange396
approved these changes
Feb 24, 2025
This was referenced Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses issue(s) #2125
Summary:
doc changes for NHSN
8 new NHSN signals were added by 2 PRs:
(both PRs were released to production as part of cmu-delphi/covidcast-indicators#2126 )
They consist of the 4 listed at https://github.com/cmu-delphi/covidcast-indicators/blob/454ac565d0a0f2b5cf557e4efb2278c278c528a9/nhsn/delphi_nhsn/constants.py#L18-L21 as well as the associated "
_prelim" versions of each.Prerequisites:
devbranchdev