Improved kubestronauts ambassadors handling scripts #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christophe Sauthier <[email protected]>
Signed-off-by: Christophe Sauthier <[email protected]>
Signed-off-by: Christophe Sauthier <[email protected]>
Signed-off-by: Christophe Sauthier <[email protected]>
| **/*.svg | ||
| **/*.png | ||
| **/*.json | ||
| **/token |
There was a problem hiding this comment.
@huats I was looking at this list of file types working thru it to consider if they had any impact on the external GHA work and I was thinking that it would probably be fine.
But then I noticed that there is a json file in this PR (suggestions.json) are you sure you want to **/*.json files in .gitgnore moving forward?
There was a problem hiding this comment.
Thanks for your feedback. Happy to keep the .json out of the gitignore file if needed of course. But since it is a working directory that has (on my end) a lot of tokens and credentials it was simply easier like this...
Please let me know what you prefer and I'll follow your judgement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.