Skip to content

Update axios version and reason in package.json#286

Merged
killagu merged 1 commit into
cnpm:masterfrom
iola1999:patch-1
Mar 31, 2026
Merged

Update axios version and reason in package.json#286
killagu merged 1 commit into
cnpm:masterfrom
iola1999:patch-1

Conversation

@iola1999
Copy link
Copy Markdown
Contributor

@iola1999 iola1999 commented Mar 31, 2026

Summary by CodeRabbit

  • Chores
    • Updated dependency version configuration to address a known issue with axios.

Signed-off-by: iola1999 <iola1999@foxmail.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 31, 2026

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Walkthrough

The pull request adds a new configuration entry to package.json under config.bug-versions mapping axios version 1.14.1 to 1.14.0 with a reference to a GitHub issue, addressing a known bug.

Changes

Cohort / File(s) Summary
Bug Version Mapping Configuration
package.json
Added entry in config.bug-versions for axios package, mapping version 1.14.1 to 1.14.0 with bug report reference to axios GitHub issue #10596.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A tiny bug in axios's thread,
So we mapped the old version instead,
One hop, one JSON line to add,
A simple fix—nothing bad! 🌟

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately and specifically describes the primary change: adding an axios version mapping and associated reason link to the package.json configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a version constraint for axios in package.json to downgrade version 1.14.1 to 1.14.0. Review feedback points out that the version number and issue reference appear to be incorrect based on current axios releases and suggests relocating the entry to maintain the logical grouping of the configuration file.

Comment thread package.json
Comment on lines +1639 to +1641
"1.14.1": {
"version": "1.14.0",
"reason": "https://github.com/axios/axios/issues/10596"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The version 1.14.1 and the issue reference 10596 for axios seem incorrect. Current axios versions are in the 1.7.x range, and the issue count in the official repository is much lower. Please verify if this is a typo (e.g., for version 1.1.4 or 1.4.1) and ensure the reference link is valid.

Comment thread package.json
Comment on lines +1638 to +1643
"axios": {
"1.14.1": {
"version": "1.14.0",
"reason": "https://github.com/axios/axios/issues/10596"
}
},
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The axios entry is inserted within a large block of packages (lines 1396–1649) that share the same reason (tinycolor supply chain attack). To maintain the logical grouping of the existing entries, this unrelated axios bug should be moved to the end of the bug-versions object.

@killagu killagu merged commit 0197703 into cnpm:master Mar 31, 2026
8 of 9 checks passed
@iola1999 iola1999 deleted the patch-1 branch March 31, 2026 02:19
fengmk2 pushed a commit that referenced this pull request Mar 31, 2026
[skip ci]

## 1.120.0 (2026-03-31)

* feat: revise axios version reasons in package.json (#287) ([00668b1](00668b1)), closes [#287](#287)
* Update axios version and reason in package.json (#286) ([0197703](0197703)), closes [#286](#286)
* chore: map npm package link to npmx.dev (#285) ([8d69473](8d69473)), closes [#285](#285)
@github-actions
Copy link
Copy Markdown

🎉 This PR is included in version 1.120.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants