bugfix - too long qhull uninstall target for repeated builds

cnr-isti-vclab · Jul 19, 2024 · dc73385 · dc73385
1 parent d1e466e
commit dc73385
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/src/external/qhull.cmake b/src/external/qhull.cmake
@@ -27,18 +27,18 @@ elseif(MESHLAB_ALLOW_DOWNLOAD_SOURCE_QHULL)
 			DIR ${MESHLAB_EXTERNAL_DOWNLOAD_DIR})
 		if (NOT download_and_unzip_SUCCESS)
 			message(STATUS "- Qhull - download failed.")
+		else()
+			# remove target uninstall to avoid duplicates
+			# todo - make PR to Qhull to solve this
+			file(READ "${QHULL_DIR}/CMakeLists.txt" FILE_CONTENTS)
+			string(REPLACE "uninstall" "qhull-uninstall" FILE_CONTENTS "${FILE_CONTENTS}")
+			file(WRITE "${QHULL_DIR}/CMakeLists.txt" "${FILE_CONTENTS}")
 		endif()
 	endif()
 
 	if (EXISTS ${QHULL_CHECK})
 		message(STATUS "- qhull - using downloaded source")
 
-		# remove target uninstall to avoid duplicates
-		# todo - make PR to Qhull to solve this
-		file(READ "${QHULL_DIR}/CMakeLists.txt" FILE_CONTENTS)
-		string(REPLACE "uninstall" "qhull-uninstall" FILE_CONTENTS "${FILE_CONTENTS}")
-		file(WRITE "${QHULL_DIR}/CMakeLists.txt" "${FILE_CONTENTS}")
-
 		set(MESSAGE_QUIET ON)
 		add_subdirectory(${QHULL_DIR} EXCLUDE_FROM_ALL)
 		unset(MESSAGE_QUIET)